New to the community? Start here

Broken CSS on Membership Listing Page

On our Membership listing page, a tag is being inserted between the ID and Class attributes.

I'm picking through the code, but am not clear on where the problem lies.

[attachments are only viewable by logged-in members] [attachments are only viewable by logged-in members]

Fri, 19 Jun 2015 7:46:29
  • Aicee Taguilaso
    • WordPress Warrior

    Hi @tim128!

    I can confirm this issue on your site, but I’m unable to see this on my own installation.

    Could you try doing a plugin conflict test by deactivating all other plugins except Membership2 Pro and switching to WP default theme. Please check again if you’re still seeing the issue.

    If everything’s working fine, activate the plugins one by one to see if there’s any plugin that’s causing the issue? See the flowchart here: https://wpmudev.com/manuals/using-wpmu-dev/getting-support/

    Thanks!

    Cheers,

    Aicee

  • Aicee Taguilaso
    • WordPress Warrior

    Hi @tim128!

    I’d like to test out some functions. Could you send your credentials here in our private contact form: https://wpmudev.com/contact/

    IMPORTANT: Make sure to select “I have a different question” for the topic and kindly send in the following:

    Subject: “Attn: Aicee“

    -WordPress admin (login url/username/password)

    -FTP credentials (host/username/password)

    -link back to this thread for reference

    Let me know once you send them in. Thanks! :slight_smile:

    Cheers,

    Aicee

  • Aicee Taguilaso
    • WordPress Warrior

    Hi @tim128!

    So here’s the quick fix I did, I just made this:

    <div id="ms-membership-wrapper-<?php echo esc_attr( $membership->id ); ?>"
    
class="<?php echo esc_attr( implode( ' ', $classes ) ); ?>">

    ..into just one line:

    <div id="ms-membership-wrapper-<?php echo esc_attr( $membership->id ); ?>" class="<?php echo esc_attr( implode( ' ', $classes ) ); ?>">

    That’s from this file /wp-content/plugins/membership/app/view/shortcode/class-ms-view-shortcode-membershipsignup.php

    I think your theme is converting that new line into br tag, so I just adjusted it into one line. This fix will be removed on plugin updates. So I’ll let the developer know about this issue, and hopefully he’ll include this fix on the next version release. :slight_smile:

    Let me know if everything’s working fine on your end! :slight_smile:

    Cheers,

    Aicee

  • Aicee Taguilaso
    • WordPress Warrior

    Hi there, @tim128! :slight_smile:

    Our plugin developer is asking for a copy of your Karma theme. That’s the one you’re currently using, right? So we can test our plugin with that theme.

    Please send the theme file here in our private contact form: https://wpmudev.com/contact/

    IMPORTANT: Make sure to select “I have a different question” for the topic and with the Subject: “Attn: Aicee“

    Please also include a link back to this thread for reference

    Thanks, Tim!

    Cheers,

    Aicee

  • Philipp
    • The Bug Hunter

    Hi Tim,

    we have adjusted the one line that caused troubles on your site. However, there are dozens of other occurances of the same code formatting in the plugin – and also in other plugins/themes, as this is valid HTML code.

    I tried to reach out to the theme author to help him fix this issue, but I could not get in contact since I did not buy the karma theme myself (the contact/help section is only available to customers)

    To make sure your theme does not break anything else I’d suggest you ask the theme author about this issue yourself: https://help.truethemes.net/

    This is the message I sent, but I only was refered to use the private help-center above. Maybe you want to send this feedback yourself to get the theme developers attention:

    We found an issue with HTML-processing that I’d like to report: A plugin outputs the following HTML on a WordPress page (note the line break)

    <div id="ms-membership-wrapper-100"
    
class="ms-membership-details ...">

    However, the Karma theme adds an extra ‘br’ tag and the page ends up using the following HTML code:

    <div id="ms-membership-wrapper-100" <br>
    
class="ms-membership-details ...">

    Short: The theme inserts a ‘br’ tag at a line-break inside an HTML tag and this breaks the HTML structur and page layout.

    Thanks for using Membership 2! Philipp :slight_smile:

  • Aicee Taguilaso
    • WordPress Warrior

    Hi Tim!

    Sorry for the late response! Hope you had a great weekend! :slight_smile:

    Yes please! We’ll see if we can find a better solution for this issue. Just please take note that this will not be a high priority on the list right now, but once we have the theme we can still check it later. Thank you Tim! :slight_smile:

    Cheers,

    Aicee