wpmu 2.7 themes

Continuing the discussion from http://mu.wordpress.org/forums/topic.php?id=11396:

When you upgrade your themes, could you please create a separate language file for the themes ? Keeping the translations in sync with the wpmu language files isn’t easy.

  • PerS
    • WPMU DEV Initiate

    no, I don’t mean a separate language file per theme.

    We could have one common themepack-lang.mo in wp-content/languages/ and including it by putting load_plugin_textdomain(‘themepack’, LANGDIR); in the “theme/functions.php”

  • Steve Atty
    • Site Builder, Child of Zeus

    Following on from the discussion on the general WPMU forums.

    Google have been making a lot of changes to the way they serve ads, for example all the colour changes are now configured from your Adsense account. So basically the code for an ad in a theme just needs the publisher-id,the ad-slot, the height and the width. Well the H and W are basically set in stone for the theme. If I’m running themeX and you are running themeX then the they both have the same H and W settings for their advert slots. All that would be different would be the publisher-id and the ad-slot id.

    So here is an idea, and slap me down if you think I’m barking mad. Rather than shipping each theme with a bit that I can search and replace why not ship each theme with the adsense code in it and use variables which are defined in a separate file. So when you ship an upgraded package all we need to do is NOT replace the define file rather than having to do a search and replace on each theme.

    Or if you want to support different ad suppliers then just put a function call in the relevant places in the theme files and put those functions in a separate include file in the theme directory.

    My reasoning behind using the separate file in each theme directory is to basically not load up tons of code,variables etc that you are not actually going to use and you’re not having to keep making DB calls to get the ad code from the DB which we do at the moment